lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ASoC: mediatek: mt8192-mt6359: Fix error handling in mt8192_mt6359_dev_probe
    On Tue, Mar 08, 2022 at 01:52:22AM +0000, Miaoqian Lin wrote:
    > The device_node pointer is returned by of_parse_phandle() with refcount
    > incremented. We should use of_node_put() on it when done.
    >
    > This function only calls of_node_put() in the regular path.
    > And it will cause refcount leak in error paths.
    > Fix this by calling of_node_put() in error handling too.
    >
    > Fixes: 4e28491a7a19 ("ASoC: mediatek: mt8192-mt6359: fix device_node leak")
    > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

    Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

    \
     
     \ /
      Last update: 2022-03-08 03:08    [W:4.286 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site