lkml.org 
[lkml]   [2022]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [v2 01/17] ASoC: mediatek: mt6366: add codec driver
From
Il 05/03/22 05:24, Jiaxin Yu ha scritto:
> On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote:
>> Il 17/02/22 14:41, Jiaxin Yu ha scritto:
>>> Mt6366 is a new version of mt6358, and they are same about audio
>>> part.
>>> So we can reuse the driver of mt6358.
>>>
>>> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
>>
>> Hello Jiaxin,
>> I'm sorry but this commit makes very little sense.
>>
>> If you want to advertise MT6366 support, please write a note and/or
>> a new compatible string inside of the mt6358 driver (and dt-
>> bindings),
>> then, please drop this commit.
>>
>
> Hello angelogioacchino,
>
> Thank you for your advice.
>
> If I add a new compatible string inside of the mt6358 driver and dt-
> bindings, then the machine driver which want to use mt6366 should
> select SND_SOC_MT6358.
>
> like below:
>
> config SND_SOC_MT8186_MT6366_DA7219_MAX98357
> tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A
> codec"
> depends on I2C && GPIOLIB
> depends on SND_SOC_MT8186 && MTK_PMIC_WRAP
> select SND_SOC_MT6366 ==> SND_SOC_MT6358
> ...
>
> I just doubt it's enough to make sense. I originally wanted to put this
> relationship in the sound/soc/codecs layer. So that this relationship
> is not perceived by users(machine driver).
> However, if the general practice is like this, I will adopt your
> suggestion. Thank you again.
>

Yes this is acceptable, please do it like that.

Thanks,
Angelo

>>
>>> ---
>>> sound/soc/codecs/Kconfig | 8 ++++++++
>>> sound/soc/codecs/Makefile | 1 +
>>> 2 files changed, 9 insertions(+)
>>>
>>> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
>>> index 8fa24783ce01..6631094678f5 100644
>>> --- a/sound/soc/codecs/Kconfig
>>> +++ b/sound/soc/codecs/Kconfig
>>> @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS
>>> imply SND_SOC_MT6351
>>> imply SND_SOC_MT6358
>>> imply SND_SOC_MT6359
>>> + imply SND_SOC_MT6366
>>> imply SND_SOC_MT6660
>>> imply SND_SOC_NAU8315
>>> imply SND_SOC_NAU8540
>>> @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET
>>> for ASoC codec soc-jack detection mechanism.
>>> Select N if you don't have jack on board.
>>>
>>> +config SND_SOC_MT6366
>>> + tristate "MediaTek MT6366 Codec"
>>> + depends on MTK_PMIC_WRAP
>>> + help
>>> + Enable support for the platform which uses MT6366 as
>>> + external codec device.
>>> +
>>> config SND_SOC_MT6660
>>> tristate "Mediatek MT6660 Speaker Amplifier"
>>> depends on I2C
>>> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
>>> index 42d00aa4ee46..1279684feaf0 100644
>>> --- a/sound/soc/codecs/Makefile
>>> +++ b/sound/soc/codecs/Makefile
>>> @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc-
>>> mt6351.o
>>> obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o
>>> obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o
>>> obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o
>>> +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o
>>> obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o
>>> obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o
>>> obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o
>>
>>
>

\
 
 \ /
  Last update: 2022-03-07 10:08    [W:0.084 / U:0.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site