Messages in this thread | | | Date | Mon, 7 Mar 2022 12:05:13 -0700 | From | Alex Williamson <> | Subject | Re: [PATCH v8 8/9] hisi_acc_vfio_pci: Add support for VFIO live migration |
| |
On Fri, 4 Mar 2022 16:57:20 -0400 Jason Gunthorpe <jgg@nvidia.com> wrote:
> On Thu, Mar 03, 2022 at 11:01:30PM +0000, Shameer Kolothum wrote: > > From: Longfang Liu <liulongfang@huawei.com> > > > > VMs assigned with HiSilicon ACC VF devices can now perform live migration > > if the VF devices are bind to the hisi_acc_vfio_pci driver. > > > > Signed-off-by: Longfang Liu <liulongfang@huawei.com> > > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> > > --- > > drivers/vfio/pci/hisilicon/Kconfig | 7 + > > .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 1078 ++++++++++++++++- > > .../vfio/pci/hisilicon/hisi_acc_vfio_pci.h | 114 ++ > > 3 files changed, 1181 insertions(+), 18 deletions(-) > > create mode 100644 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.h > > > > diff --git a/drivers/vfio/pci/hisilicon/Kconfig b/drivers/vfio/pci/hisilicon/Kconfig > > index dc723bad05c2..2a68d39f339f 100644 > > --- a/drivers/vfio/pci/hisilicon/Kconfig > > +++ b/drivers/vfio/pci/hisilicon/Kconfig > > @@ -3,6 +3,13 @@ config HISI_ACC_VFIO_PCI > > tristate "VFIO PCI support for HiSilicon ACC devices" > > depends on ARM64 || (COMPILE_TEST && 64BIT) > > depends on VFIO_PCI_CORE > > + depends on PCI && PCI_MSI > > PCI is already in the depends from the 2nd line in > drivers/vfio/pci/Kconfig, but it is harmless > > > + depends on UACCE || UACCE=n > > + depends on ACPI > > Scratching my head a bit on why we have these
Same curiosity from me, each of the CRYPTO_DEV_HISI_* options selected also depend on these so they seem redundant.
I think we still require acks from Bjorn and Zaibo for select patches in this series.
From me, I would request a MAINTAINERS entry similar to the one the mlx5 folks added for their driver. This should be in patch 4/9 where the driver is originally added. Thanks,
Alex
| |