Messages in this thread | | | From | Ulf Hansson <> | Date | Mon, 7 Mar 2022 13:17:28 +0100 | Subject | Re: [PATCH] mmc: wmt-sdmmc: Fix an error handling path in wmt_mci_probe() |
| |
On Sun, 6 Mar 2022 at 18:44, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > A dma_free_coherent() call is missing in the error handling path of the > probe, as already done in the remove function. > > Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > I've not been able to find a Fixes tag because of the renaming of > function and files. > However, it looks old (before 2008)
Let's keep the above and monitor what the backport process reports.
Applied for next, thanks!
Kind regards Uffe
> --- > drivers/mmc/host/wmt-sdmmc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c > index 163ac9df8cca..8e18f01c0938 100644 > --- a/drivers/mmc/host/wmt-sdmmc.c > +++ b/drivers/mmc/host/wmt-sdmmc.c > @@ -863,6 +863,8 @@ static int wmt_mci_probe(struct platform_device *pdev) > return 0; > fail6: > clk_put(priv->clk_sdmmc); > + dma_free_coherent(&pdev->dev, mmc->max_blk_count * 16, > + priv->dma_desc_buffer, priv->dma_desc_device_addr); > fail5: > free_irq(dma_irq, priv); > fail4: > -- > 2.32.0 >
| |