Messages in this thread | | | Date | Mon, 7 Mar 2022 07:27:44 +0700 | From | Ammar Faizi <> | Subject | Re: [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails |
| |
On 3/3/22 9:32 AM, Ammar Faizi wrote: > It looks like this now. Yazen, Alviro, please review the > following patch. If you think it looks good, I will submit > it for the v5. > > From 91a447f837d502b7a040cd68f333fb98f4b941d9 Mon Sep 17 00:00:00 2001 > From: Ammar Faizi <ammarfaizi2@gnuweeb.org> > Date: Thu, 3 Mar 2022 09:22:17 +0700 > Subject: [PATCH v5 2/2] x86/MCE/AMD: Fix memory leak when `threshold_create_bank()` fails > > In mce_threshold_create_device(), if threshold_create_bank() fails, the > @bp will be leaked, because mce_threshold_remove_device() will not free > the @bp. It only frees the @bp when we've already written the @bp to > the @threshold_banks per-CPU variable, but at the point, we haven't. > > Fix this by extracting the cleanup part into a new static function > _mce_threshold_remove_device(), then use it from create/remove device > function. Also, eliminate the "goto out_err". Just early return inside > the loop if we fail. > > Cc: Borislav Petkov <bp@alien8.de> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: stable@vger.kernel.org # v5.8+ > Fixes: 6458de97fc15 ("x86/mce/amd: Straighten CPU hotplug path") > Co-authored-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> > Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org> > Co-authored-by: Yazen Ghannam <yazen.ghannam@amd.com> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com> > Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Hi,
It's Monday morning...
Friendly ping for Yazen from AMD. What do you think of this patch? If it looks good, I will submit it for the v5 revision. See the ref below if you lost track of the full message.
Ref: https://lore.kernel.org/lkml/9dfe087a-f941-1bc4-657d-7e7c198888ff@gnuweeb.org/
Thanks!
-- Ammar Faizi
| |