Messages in this thread | | | From | Christophe Leroy <> | Subject | Re: [PATCH -next] powerpc/spufs: Fix build warning when CONFIG_PROC_FS=n | Date | Sun, 6 Mar 2022 20:04:37 +0000 |
| |
Le 05/03/2022 à 13:31, YueHaibing a écrit : > arch/powerpc/platforms/cell/spufs/sched.c:1055:12: warning: ‘show_spu_loadavg’ defined but not used [-Wunused-function] > static int show_spu_loadavg(struct seq_file *s, void *private) > ^~~~~~~~~~~~~~~~ > > Mark this as __maybe_unused to fix this.
Marking it as __maybe_unused doesn't fix it. It just pushes the dust under the carpet.
proc_create_single macro should be fix to avoid that warning.
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/powerpc/platforms/cell/spufs/sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c > index d058f6233e66..c46835625133 100644 > --- a/arch/powerpc/platforms/cell/spufs/sched.c > +++ b/arch/powerpc/platforms/cell/spufs/sched.c > @@ -1052,7 +1052,7 @@ void spuctx_switch_state(struct spu_context *ctx, > } > } > > -static int show_spu_loadavg(struct seq_file *s, void *private) > +static int __maybe_unused show_spu_loadavg(struct seq_file *s, void *private) > { > int a, b, c; >
| |