Messages in this thread | | | Date | Sun, 6 Mar 2022 13:07:50 +0100 | Subject | Re: [PATCH v3 2/2] dt-bindings: usb: Add bindings doc for Sunplus EHCI driver | From | Krzysztof Kozlowski <> |
| |
On 06/03/2022 07:10, Vincent Shih wrote: > Add bindings doc for Sunplus EHCI driver > > Signed-off-by: Vincent Shih <vincent.sunplus@gmail.com> > --- > Changes in v2: > - Address the comments by Rob Herring. > > .../bindings/usb/sunplus,sp7021-usb-ehci.yaml | 63 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > > diff --git a/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > new file mode 100644 > index 0000000..905f68c > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/sunplus,sp7021-usb-ehci.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/sunplus,sp7021-usb-ehci.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus SP7021 EHCI Controller Device Tree bindings
s/Device Tree bindings// (title describes hardware)
> + > +allOf: > + - $ref: usb-hcd.yaml# > + > +maintainers: > + - Vincent Shih <vincent.sunplus@gmail.com> > + > +properties: > + compatible: > + const: sunplus,sp7021-usb2-ehci
You do not use this compatible in the driver.
> + > + clocks: > + maxItems: 1 > + > + resets: > + minItems: 1
Suddenly it became minItems. This looks odd, it should be maxItems: 1 rather. How many reset lines do you have there?
> + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + phys: > + maxItems: 1 > + > + phy-names: > + maxItems: 1
phy-names needs list of names.
> + > +required: > + - compatible > + - clocks > + - resets > + - reg > + - interrupts > + - phys > + - phy-names > + > +additionalProperties: false
This should be unevaluatedProperties:false, because you reference usb-hcd schema.
> + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + sp_ehci0: usb@9c102100 { > + compatible = "sunplus,sp7021-usb-ehci"; > + clocks = <&clkc 0x3a>; > + resets = <&rstc 0x2a>; > + reg = <0x9c102100 0x68>;
reg goes after compatible in DTS.
Best regards, Krzysztof
| |