Messages in this thread | | | Date | Fri, 4 Mar 2022 08:07:21 -0800 | Subject | Re: [PATCH bpf-next v2] bpf: Replace strncpy() with strscpy() | From | Yonghong Song <> |
| |
On 3/3/22 11:04 PM, Yuntao Wang wrote: > Using strncpy() on NUL-terminated strings is considered deprecated[1]. > Moreover, if the length of 'task->comm' is less than the destination buffer > size, strncpy() will NUL-pad the destination buffer, which is a needless > performance penalty. > > Replacing strncpy() with strscpy() fixes all these issues. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings > > Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
Acked-by: Yonghong Song <yhs@fb.com>
| |