lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] dt-bindings:pwm:Add bindings doc for Sunplus SoC PWM Driver
From
On 04/03/2022 07:20, Hammer Hsieh wrote:
> Add bindings doc for Sunplus SoC PWM Driver

You miss spaces in the subject.

>
> Signed-off-by: Hammer Hsieh <hammerh0314@gmail.com>
> ---
> Changes in v2:
> - Addressed all comments from Rob Herring.
> modify author's mail match Signed-off-by.
> - rebase kernel to 5.17 rc5
>
> .../devicetree/bindings/pwm/pwm-sunplus.yaml | 40 ++++++++++++++++++++++
> MAINTAINERS | 5 +++
> 2 files changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
> new file mode 100644
> index 0000000..19fe5d5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-sunplus.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/pwm-sunplus.yaml#

Is it going to be one binding for all Sunplus SoCs? Existing and future?

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SoC PWM Controller
> +
> +maintainers:
> + - Hammer Hsieh <hammerh0314@gmail.com>
> +

allOf with pwm.yaml
Then unevaluatedProperties instead of additionalProperties.


> +properties:
> + '#pwm-cells':
> + const: 2
> +
> + compatible:

Commpatible goes first. Rest of properties you could order
alphabetically. Similar approach in required.


> + items:
> + - const: sunplus,sp7021-pwm
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:

compatible

> + - reg
> + - clocks


> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pwm: pwm@9c007a00 {
> + #pwm-cells = <2>;
> + compatible = "sunplus,sp7021-pwm";

compatible goes first, then reg.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-04 16:02    [W:0.071 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site