lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] dt-bindings: mfd: Fix pinctrl node name warnings
On Fri, Mar 04, 2022 at 09:58:37AM +0000, Charles Keepax wrote:
> On Thu, Mar 03, 2022 at 01:47:37PM -0600, Rob Herring wrote:
> > The recent addition pinctrl.yaml in commit c09acbc499e8 ("dt-bindings:
> > pinctrl: use pinctrl.yaml") resulted in some node name warnings:
> >
> > Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml: \
> > lochnagar-pinctrl: $nodename:0: 'lochnagar-pinctrl' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> > Documentation/devicetree/bindings/mfd/cirrus,madera.example.dt.yaml: \
> > codec@1a: $nodename:0: 'codec@1a' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> > Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml: \
> > pin-controller@1c0: $nodename:0: 'pin-controller@1c0' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
> >
> > Fix the node names to the preferred 'pinctrl'. For cirrus,madera,
> > nothing from pinctrl.yaml schema is used, so just drop the reference.
> >
> > Fixes: c09acbc499e8 ("dt-bindings: pinctrl: use pinctrl.yaml")
> > Cc: Rafał Miłecki <rafal@milecki.pl>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > diff --git a/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
> > index c00ad3e21c21..975a46f3c46f 100644
> > --- a/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/cirrus,lochnagar.yaml
> > @@ -126,7 +126,7 @@ properties:
> > clock-frequency:
> > const: 12288000
> >
> > - lochnagar-pinctrl:
> > + pinctrl:
> > type: object
> > $ref: /schemas/pinctrl/cirrus,lochnagar.yaml#
> >
>
> We also need to update the required properties and the example here.

Yes, see v3.

Rob

\
 
 \ /
  Last update: 2022-03-04 14:46    [W:0.038 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site