lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 2/2] usb: typec: anx7411: Add Analogix PD ANX7411 support
    On Fri, Mar 04, 2022 at 10:29:36AM +0800, Xin Ji wrote:
    > On Thu, Mar 03, 2022 at 03:13:33PM +0200, Heikki Krogerus wrote:
    > > On Thu, Mar 03, 2022 at 10:47:57AM +0800, Xin Ji wrote:
    > > > On Wed, Mar 02, 2022 at 02:03:18PM +0200, Heikki Krogerus wrote:
    > > > > Hi,
    > > > >
    > > > > This does not apply on top of Greg's latest usb-next branch. You need
    > > > > to rebase this. There are also a few more nitpicks below.
    > > >
    > > > Hi, I didn't found tcpci.h in include/linux/usb/
    > >
    > > I'm asking you to create the file.
    > >
    > > So create a separate patch where you move the register definitions and
    > > command definitions from drivers/usb/typec/tcpm/tcpci.h to
    > > include/linux/usb/tcpci.h
    > Hi heikki, I'm confused, do you mean move total tcpci.h to
    > include/linux/usb/ directory or just move our driver patch used register
    > definitions and command to "include/linux/usb/tcpci.h"?
    >
    > And I think the other way is, our driver patch just include
    > "tcpm/tcpci.h" is better(no need to create new file). What do you think?

    I would prefer that you just introduce the global header for them.

    thanks,

    --
    heikki

    \
     
     \ /
      Last update: 2022-03-04 13:29    [W:5.923 / U:1.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site