lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/5] slab cleanups
On Fri, Mar 04, 2022 at 12:50:21PM +0100, Marco Elver wrote:
> On Fri, 4 Mar 2022 at 07:34, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote:
> >
> > Changes from v1:
> > Now SLAB passes requests larger than order-1 page
> > to page allocator.
> >
> > Adjusted comments from Matthew, Vlastimil, Rientjes.
> > Thank you for feedback!
> >
> > BTW, I have no idea what __ksize() should return when an object that
> > is not allocated from slab is passed. both 0 and folio_size()
> > seems wrong to me.
>
> Didn't we say 0 would be the safer of the two options?
> https://lkml.kernel.org/r/0e02416f-ef43-dc8a-9e8e-50ff63dd3c61@suse.cz
>

Oh sorry, I didn't understand why 0 was safer when I was reading it.

Reading again, 0 is safer because kasan does not unpoison for
wrongly passed object, right?

> > Hello, these are cleanup patches for slab.
> > Please consider them for slab-next :)
> >
> > Any comments will be appreciated.
> > Thanks.
> >
> > Hyeonggon Yoo (5):
> > mm/slab: kmalloc: pass requests larger than order-1 page to page
> > allocator
> > mm/sl[au]b: unify __ksize()
> > mm/sl[auo]b: move definition of __ksize() to mm/slab.h
> > mm/slub: limit number of node partial slabs only in cache creation
> > mm/slub: refactor deactivate_slab()
> >
> > include/linux/slab.h | 36 ++++++------
> > mm/slab.c | 51 ++++++++---------
> > mm/slab.h | 21 +++++++
> > mm/slab_common.c | 20 +++++++
> > mm/slob.c | 1 -
> > mm/slub.c | 130 ++++++++++++-------------------------------
> > 6 files changed, 114 insertions(+), 145 deletions(-)
> >
> > --
> > 2.33.1
> >

--
Thank you, You are awesome!
Hyeonggon :-)

\
 
 \ /
  Last update: 2022-03-04 13:03    [W:0.480 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site