Messages in this thread | | | From | Zong Li <> | Date | Fri, 4 Mar 2022 18:06:57 +0800 | Subject | Re: [PATCH v6 1/3] dt-bindings: Add dma-channels property and modify compatible |
| |
On Fri, Mar 4, 2022 at 5:09 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 04/03/2022 09:42, Zong Li wrote: > > Add dma-channels property, then we can determine how many channels there > > by device tree, rather than statically defining it in PDMA driver. > > In addition, we also modify the compatible for PDMA versioning scheme. > > > > Signed-off-by: Zong Li <zong.li@sifive.com> > > Suggested-by: Palmer Dabbelt <palmer@rivosinc.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> > > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > > --- > > .../bindings/dma/sifive,fu540-c000-pdma.yaml | 19 +++++++++++++++++-- > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > Can you add subystem/driver prefix to the subject? In current form it > looks generic, but it is actually specific, so: > > dt-bindings: dma-engine: sifive,fu540: >
Thanks for your correction, I will send the next version to change it.
> Best regards, > Krzysztof
| |