Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 4 Mar 2022 09:59:12 +0100 | Subject | Re: [PATCH] dt-bindings: kbuild: Print a warning if yamllint is not found |
| |
Hi Rob,
On Thu, Mar 3, 2022 at 11:15 PM Rob Herring <robh@kernel.org> wrote: > Running yamllint is effectively required for binding schemas, so print a > warning if not found rather than silently skipping running it. > > Signed-off-by: Rob Herring <robh@kernel.org>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/Makefile > +++ b/Documentation/devicetree/bindings/Makefile > @@ -3,7 +3,8 @@ DT_DOC_CHECKER ?= dt-doc-validate > DT_EXTRACT_EX ?= dt-extract-example > DT_MK_SCHEMA ?= dt-mk-schema > > -DT_SCHEMA_LINT = $(shell which yamllint) > +DT_SCHEMA_LINT := $(shell which yamllint || \ > + echo "warning: yamllint not installed, skipping. To install, run 'pip install yamllint'" >&2)
Do we want to encourage people to use pip, instead of their distro's package manager? At least Debian/Ubuntu provide yamllint packages.
So perhaps drop the install rule?
> > DT_SCHEMA_MIN_VERSION = 2021.2.1
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |