Messages in this thread | | | From | David Gow <> | Date | Fri, 4 Mar 2022 15:52:05 +0800 | Subject | Re: [PATCH v2] binfmt_elf: Introduce KUnit test |
| |
On Fri, Mar 4, 2022 at 12:48 PM Kees Cook <keescook@chromium.org> wrote: > > Adds simple KUnit test for some binfmt_elf internals: specifically a > regression test for the problem fixed by commit 8904d9cd90ee ("ELF: > fix overflow in total mapping size calculation"). > > $ ./tools/testing/kunit/kunit.py run --arch x86_64 \ > --kconfig_add CONFIG_IA32_EMULATION=y '*binfmt_elf' > ... > [19:41:08] ================== binfmt_elf (1 subtest) ================== > [19:41:08] [PASSED] total_mapping_size_test > [19:41:08] =================== [PASSED] binfmt_elf ==================== > [19:41:08] ============== compat_binfmt_elf (1 subtest) =============== > [19:41:08] [PASSED] total_mapping_size_test > [19:41:08] ================ [PASSED] compat_binfmt_elf ================ > [19:41:08] ============================================================ > [19:41:08] Testing complete. Passed: 2, Failed: 0, Crashed: 0, Skipped: 0, Errors: 0 > > Cc: Eric Biederman <ebiederm@xmission.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > This is now at the top of my for-next/execve tree > v1: https://lore.kernel.org/lkml/20220224054332.1852813-1-keescook@chromium.org > v2: > - improve commit log > - fix comment URL (Daniel) > - drop redundant KUnit Kconfig help info (Daniel) > - note in Kconfig help that COMPAT builds add a compat test (David) > ---
This looks good to me, and works fine with those two prerequisite patches from your tree: - ELF: Properly redefine PT_GNU_* in terms of PT_LOOS - ELF: fix overflow in total mapping size calculation (I even played a few of the games which triggered the ELF bug to make sure it was fixed, too. :-) )
Reviewed-by: David Gow <davidgow@google.com>
Cheers, -- David [unhandled content-type:application/pkcs7-signature] | |