lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()
Hi,

On Tue, Mar 01, 2022 at 04:16:19PM +0800, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

Thanks, queued.

-- Sebastian

> drivers/power/supply/da9150-fg.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
> index e63fa62d1943..8c5e2c49d6c1 100644
> --- a/drivers/power/supply/da9150-fg.c
> +++ b/drivers/power/supply/da9150-fg.c
> @@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
>
> /* Register IRQ */
> irq = platform_get_irq_byname(pdev, "FG");
> - if (irq < 0) {
> - dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
>
> ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
> IRQF_ONESHOT, "FG", fg);
> --
> 2.20.1.7.g153144c
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-03-04 22:16    [W:0.068 / U:2.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site