lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH v5 017/104] KVM: TDX: Add helper functions to print TDX SEAMCALL error
    Date
    From: Isaku Yamahata <isaku.yamahata@intel.com>

    Add helper functions to print out errors from the TDX module in a uniform
    manner.

    Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
    ---
    arch/x86/kvm/Makefile | 2 +-
    arch/x86/kvm/vmx/seamcall.h | 2 ++
    arch/x86/kvm/vmx/tdx_error.c | 22 ++++++++++++++++++++++
    3 files changed, 25 insertions(+), 1 deletion(-)
    create mode 100644 arch/x86/kvm/vmx/tdx_error.c

    diff --git a/arch/x86/kvm/Makefile b/arch/x86/kvm/Makefile
    index e8f83a7d0dc3..3d6550c73fb5 100644
    --- a/arch/x86/kvm/Makefile
    +++ b/arch/x86/kvm/Makefile
    @@ -24,7 +24,7 @@ kvm-$(CONFIG_KVM_XEN) += xen.o
    kvm-intel-y += vmx/vmx.o vmx/vmenter.o vmx/pmu_intel.o vmx/vmcs12.o \
    vmx/evmcs.o vmx/nested.o vmx/posted_intr.o vmx/main.o
    kvm-intel-$(CONFIG_X86_SGX_KVM) += vmx/sgx.o
    -kvm-intel-$(CONFIG_INTEL_TDX_HOST) += vmx/tdx.o vmx/seamcall.o
    +kvm-intel-$(CONFIG_INTEL_TDX_HOST) += vmx/tdx.o vmx/seamcall.o vmx/tdx_error.o

    kvm-amd-y += svm/svm.o svm/vmenter.o svm/pmu.o svm/nested.o svm/avic.o svm/sev.o

    diff --git a/arch/x86/kvm/vmx/seamcall.h b/arch/x86/kvm/vmx/seamcall.h
    index 604792e9a59f..5ac419cd8e27 100644
    --- a/arch/x86/kvm/vmx/seamcall.h
    +++ b/arch/x86/kvm/vmx/seamcall.h
    @@ -16,6 +16,8 @@ struct tdx_module_output;
    u64 kvm_seamcall(u64 op, u64 rcx, u64 rdx, u64 r8, u64 r9, u64 r10,
    struct tdx_module_output *out);

    +void pr_tdx_error(u64 op, u64 error_code, const struct tdx_module_output *out);
    +
    #endif /* !__ASSEMBLY__ */

    #endif /* CONFIG_INTEL_TDX_HOST */
    diff --git a/arch/x86/kvm/vmx/tdx_error.c b/arch/x86/kvm/vmx/tdx_error.c
    new file mode 100644
    index 000000000000..61ed855d1188
    --- /dev/null
    +++ b/arch/x86/kvm/vmx/tdx_error.c
    @@ -0,0 +1,22 @@
    +// SPDX-License-Identifier: GPL-2.0
    +/* functions to record TDX SEAMCALL error */
    +
    +#include <linux/kernel.h>
    +#include <linux/bug.h>
    +
    +#include "tdx_ops.h"
    +
    +void pr_tdx_error(u64 op, u64 error_code, const struct tdx_module_output *out)
    +{
    + if (!out) {
    + pr_err_ratelimited("SEAMCALL[%lld] failed: 0x%llx\n",
    + op, error_code);
    + return;
    + }
    +
    + pr_err_ratelimited(
    + "SEAMCALL[%lld] failed: 0x%llx "
    + "RCX 0x%llx, RDX 0x%llx, R8 0x%llx, R9 0x%llx, R10 0x%llx, R11 0x%llx\n",
    + op, error_code,
    + out->rcx, out->rdx, out->r8, out->r9, out->r10, out->r11);
    +}
    --
    2.25.1
    \
     
     \ /
      Last update: 2022-03-04 21:07    [W:2.096 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site