Messages in this thread | | | Date | Fri, 4 Mar 2022 11:18:16 -0800 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] x86/bug: __WARN_FLAGS: prevent shadowing by renaming local variable f to __flags |
| |
On Thu, Mar 03, 2022 at 08:07:55PM +0900, Vincent Mailhol wrote: > This patch renames the variable from f to __flags (with two underscore > prefixes as suggested in the Linux kernel coding style [1]) in order > to prevent collisions. > > [1] Linux kernel coding style, section 12) Macros, Enums and RTL, > paragraph 5) namespace collisions when defining local variables in > macros resembling functions > https://www.kernel.org/doc/html/v4.10/process/coding-style.html#macros-enums-and-rtl
Looks good to me.
> > fixes: bfb1a7c91fb7 ("x86/bug: Merge annotate_reachable() into > _BUG_FLAGS() asm") > Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Fixes tag should be capitalized and in a single line, like:
Fixes: bfb1a7c91fb7 ("x86/bug: Merge annotate_reachable() into _BUG_FLAGS() asm")
Otherwise:
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |