lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] arm64: hyperv: make the format of 'Hyper-V: Host Build' output match x86
Date
From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Friday, March 4, 2022 4:24 AM
>
> Currently, the following is observed on Hyper-V/ARM:
>
> Hyper-V: Host Build 10.0.22477.1061-1-0
>
> This differs from similar output on x86:
>
> Hyper-V Host Build:20348-10.0-1-0.1138
>
> and this is inconvenient. As x86 was the first to introduce the current
> format and to not break existing tools parsing it, change the format on
> ARM to match.

Interesting. I had explicitly output this line differently on ARM64 so
that the output is in the standard form of a Windows version number,
which is what the Host Build value actually is. My intent is to fix the
x86 side as well. I had not anticipated there being automated parsing
of these strings.

I had also put the colon in the place to be consistent with most
other Hyper-V messages. I know: picky, picky. :-)

What's the impact of changing the tools that parse it so that
either version could be handled?

Michael

>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/arm64/hyperv/mshyperv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c
> index bbbe351e9045..7b9c1c542a77 100644
> --- a/arch/arm64/hyperv/mshyperv.c
> +++ b/arch/arm64/hyperv/mshyperv.c
> @@ -60,8 +60,8 @@ static int __init hyperv_init(void)
> b = result.as32.b;
> c = result.as32.c;
> d = result.as32.d;
> - pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
> - b >> 16, b & 0xFFFF, a, d & 0xFFFFFF, c, d >> 24);
> + pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n",
> + a, b >> 16, b & 0xFFFF, c, d >> 24, d & 0xFFFFFF);
>
> ret = hv_common_init();
> if (ret)
> --
> 2.35.1

\
 
 \ /
  Last update: 2022-03-04 19:24    [W:1.347 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site