lkml.org 
[lkml]   [2022]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH 1/3] ceph: fix error path in ceph_readdir()
    From
    Date
    On Fri, 2022-03-04 at 16:14 +0000, Luís Henriques wrote:
    > This was introduced by commit
    >
    > "ceph: add support to readdir for encrypted filenames"
    >
    > It will eventually leak the fscrypt_str names in this error path.
    >
    > Signed-off-by: Luís Henriques <lhenriques@suse.de>
    > ---
    > fs/ceph/dir.c | 1 -
    > 1 file changed, 1 deletion(-)
    >
    > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
    > index 44395aae7259..0bcb677d2199 100644
    > --- a/fs/ceph/dir.c
    > +++ b/fs/ceph/dir.c
    > @@ -500,7 +500,6 @@ static int ceph_readdir(struct file *file, struct dir_context *ctx)
    > next_offset);
    > if (err) {
    > ceph_mdsc_put_request(dfi->last_readdir);
    > - return err;
    > goto out;
    > }
    > } else if (req->r_reply_info.dir_end) {

    This doesn't seem to apply to the current wip-fscrypt tree. Are you
    working against an older branch, perhaps?

    --
    Jeff Layton <jlayton@kernel.org>

    \
     
     \ /
      Last update: 2022-03-04 19:17    [W:5.869 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site