lkml.org 
[lkml]   [2022]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v5 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021
Date
Dear Krzysztof:

> > Add mmc yaml file for Sunplus SP7021
>
> s/mmc/MMC/
> s/yaml/YAML/
> And a full stop.
>

OK, I will modify it.

> Please rebase your changes on recent Linux kernel, because you skip Cc-ing me
> all the time, so I assume you have some old Maintainers file.
>

OK, I will pay attention.

> >
> > Signed-off-by: Tony Huang <tonyhuang.sunplus@gmail.com>
> > ---
> > Changes in v5:
> > - Addressed comments from Krzysztof.
> >
> > .../devicetree/bindings/mmc/sunplus,mmc.yaml | 64
> ++++++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 70 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
> > b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
> > new file mode 100644
> > index 0000000..92537d0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/sunplus,mmc.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(C) Sunplus Ltd. Co. 2021 %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mmc/sunplus,mmc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sunplus MMC Controller
> > +
> > +maintainers:
> > + - Tony Huang <tonyhuang.sunplus@gmail.com>
> > + - Li-hao Kuo <lhjeff911@gmail.com>
> > +
> > +allOf:
> > + - $ref: "mmc-controller.yaml"
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - sunplus,sp7021-mmc
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + max-frequency: true
>
> I think you do not need this.
>

OK, I will modify it.

> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - resets
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + mmc0: mmc@9c003b00 {
> > + compatible = "sunplus,mmc-v2";
> > + reg = <0x9c003b00 0x180>;
> > + interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clkc 0x4e>;
> > + resets = <&rstc 0x3e>;
> > + bus-width = <8>;
> > + max-frequency = <52000000>;
> > + non-removable;
> > + disable-wp;
> > + cap-mmc-highspeed;
> > + mmc-ddr-3_3v;
> > + no-sdio;
> > + no-sd;
> > + };
> > +
> > diff --git a/MAINTAINERS b/MAINTAINERS index fb18ce7..42498b2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18242,6 +18242,12 @@ L: netdev@vger.kernel.org
> > S: Maintained
> > F: drivers/net/ethernet/dlink/sundance.c
> >
> > +SUNPLUS MMC DRIVER
> > +M: Tony Huang <tonyhuang.sunplus@gmail.com>
> > +M: Li-hao Kuo <lhjeff911@gmail.com>
> > +S: Maintained
> > +F: Documentation/devicetree/bindings/mmc/sunplu,mmc.yaml
>
> I pointed this already for your v4.
>

Sorry, I will modify it.

\
 
 \ /
  Last update: 2022-03-31 11:37    [W:0.048 / U:2.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site