Messages in this thread | | | Date | Thu, 31 Mar 2022 10:23:23 +0200 | Subject | Re: [PATCH v2] thermal: exynos: fix masking value for exynos7 temp_error | From | Krzysztof Kozlowski <> |
| |
On 31/03/2022 09:28, Sang Min Kim wrote: >
Unneeded empty line at beginning of msg.
> Modify mask value for the temp_error in the sanitize_temp_error() function. > > Fixes: aef27b658b43 ("thermal: exynos: use sanitize_temp_error() in exynos7_tmu_initialize()") > masked temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff) value even in the case > of EXYNOS7. > In addition, when entering the if statement, both temp_error1 and 2 are > masked with EXYNOS_TMU_TEMP_MASK(0xff). > > By modifying to use the previously declared local variable tmu_temp_mask, > the mask value suitable for the SOC can be applied. >
Fixes tag goes next to other tags, so usually before Signed-off-by. Check some existing commits for examples.
> Signed-off-by: sangmin kim <hypmean.kim@samsung.com>
You received by Reviewed-by tag, so you should include it in v2. Don't skip them.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> --- > V1 -> V2: Add fixes tag > > drivers/thermal/samsung/exynos_tmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >
Best regards, Krzysztof
| |