lkml.org 
[lkml]   [2022]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT pull] x86/irq for v5.18-rc1
On Mon, 21 Mar 2022, Linus Torvalds wrote:

> > - Handle the IRT routing table format in AMI BIOSes correctly
>
> *Very* minor nit here in the hope of future cleanups: the other x86
> irq routing table structions (Christ, that's a sentence that shouldn't
> exist in a sane world) use "__attribute__((packed))" and this one uses
> "__packed".

I have reviewed and reverified the code for resubmission now and frankly
I don't know where this "__packed" artefact has come from. I certainly
have "__attribute__((packed))" in all my copies of the change including
one I have submitted (though `checkpatch.pl' does want it indeed to be
`__packed' instead).

Also accessing memory beyond __va(0x100000) does not appear to crash on
my 32-bit x86 machine, so it must be something specific to x86-64. Not an
excuse for a range overrun of course, but still odd (and as I previously
mentioned I find it odd too that this code is ever run for x86-64 in the
first place).

Finally, following your suggestion I have added verification for a range
overrun for the whole table for both the existing $PIR format and the new
$IRT format. It isn't a big deal and we shouldn't trust external sources
of data.

Maciej

\
 
 \ /
  Last update: 2022-03-31 09:14    [W:0.092 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site