Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Fri, 1 Apr 2022 11:33:16 +0800 | Subject | Re: [PATCH v4] media: hantro: Implement support for encoder commands |
| |
On Fri, Apr 1, 2022 at 4:18 AM Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > > On Thu, Mar 31, 2022 at 05:16:28PM +0800, Chen-Yu Tsai wrote: > > The V4L2 stateful encoder uAPI specification requires that drivers > > support the ENCODER_CMD ioctl to allow draining of buffers. This > > however was not implemented, and causes issues for some userspace > > applications. > > > > Implement support for the ENCODER_CMD ioctl using v4l2-mem2mem helpers. > > This is entirely based on existing code found in the vicodec test > > driver. > > > > Fixes: 775fec69008d ("media: add Rockchip VPU JPEG encoder driver") > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > > I believe Nicolas tested the patch before the splitting, > so this is probably Tested-by as well.
The code flow changed, so I believe a re-test is warranted.
ChenYu
| |