Messages in this thread | | | Date | Wed, 30 Mar 2022 09:20:26 -0600 | From | Logan Gunthorpe <> | Subject | Re: [PATCH V4 1/1] Intel Sky Lake-E host root ports check. |
| |
On 2022-03-30 08:08, Shlomo Pongratz wrote: > In commit 7b94b53db34f ("PCI/P2PDMA: Add Intel Sky Lake-E Root Ports B, C, D to > the whitelist") > Andrew Maier added the Sky Lake-E additional devices > 2031, 2032 and 2033 root ports to the already existing 2030 device. > > The Intel devices 2030, 2031, 2032 and 2033 which are root ports A, B, C and D, > respectively and if all exist they will occupy slots 0 till 3 in that order. > > The original code handled only the case where the devices in the whiltlist are
s/whiltlist/whitelist/
> host bridges and assumed that they will be found on slot 0. > > This assumption doesn't hold for root ports so an explicit test was added to > cover this case. > > Signed-off-by: Shlomo Pongratz <shlomop@pliops.com>
This patch looks good to me. Much cleaner and easier to understand than the previous ones.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Thanks,
Logan
| |