Messages in this thread Patch in this message | | | From | Cristian Marussi <> | Subject | [PATCH 08/22] firmware: arm_scmi: Remove unneeded NULL termination of clk name | Date | Wed, 30 Mar 2022 16:05:37 +0100 |
| |
The string array 'name' inside struct scmi_clock_info holds the clock name which was successfully retrieved by querying the SCMI platform, unless the related underlying SCMI command failed.
Anyway, such scmi_clock_info structure is allocated using devm_kcalloc() which in turn internally appends a __GFP_ZERO flag to its invocation: as a consequence the string 'name' field does not need to be zeroed when we fail to get the clock name via SCMI, it is already NULL terminated.
Remove unneeded explicit NULL termination.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com> --- drivers/firmware/arm_scmi/clock.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c index 32ccac457d20..7adf99b92bf6 100644 --- a/drivers/firmware/arm_scmi/clock.c +++ b/drivers/firmware/arm_scmi/clock.c @@ -129,8 +129,6 @@ static int scmi_clock_attributes_get(const struct scmi_protocol_handle *ph, if (t->rx.len == sizeof(*attr)) clk->enable_latency = le32_to_cpu(attr->clock_enable_latency); - } else { - clk->name[0] = '\0'; } ph->xops->xfer_put(ph, t); -- 2.32.0
| |