Messages in this thread | | | Date | Wed, 30 Mar 2022 16:36:04 +0200 | Subject | Re: [PATCH] perf tools: Stop depending on .git files for building PERF-VERSION-FILE | From | Matthieu Baerts <> |
| |
On 30/03/2022 16:30, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 30, 2022 at 11:28:12AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Mar 30, 2022 at 04:22:35PM +0200, Matthieu Baerts escreveu: >>> On 30/03/2022 16:12, Arnaldo Carvalho de Melo wrote: >>>>> Thank you for your patch, I just tested it and it also fixes the issue I >>>>> reported! > >>>> I'm taking this as a: > >>>> Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net> > >>>> Ok? > >>> Yes, OK for me, thank you! > >>> I never know what maintainers prefer when there is already a >>> "Reported-by" tag so I didn't specify it but I will do next time. > >> Right, I'll stick both R-by and T-by. > >> There are cases where people just report and don't test, or just ack. > > But when you actually provide the: > > Tested-by: Matthieu Baerts <matthieu.baerts@tessares.net> > > It makes the lives of maintainers using b4 easier, as it'll collect > those.
I agree it is clearer having both tags. On my side, some people are often asking not to their name in multiple tags but instead combining tags, e.g. Reported-and-tested-by. But Patchwork doesn't like that and I have to add the tag manually when applying the patch. I guess many tools don't like these combined tags!
Anyway, next time I add it and let the maintainer drop / modify it if they prefer :)
> About b4: https://people.kernel.org/monsieuricon/introducing-b4-and-patch-attestation
Excellent and very useful tool, I agree :-)
Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
| |