Messages in this thread | | | Date | Wed, 30 Mar 2022 19:57:57 +0800 | From | Lu Baolu <> | Subject | Re: [PATCH RFC v2 02/11] iommu: Add iommu_group_singleton_lockdown() |
| |
Hi Kevin,
On 2022/3/30 14:50, Tian, Kevin wrote: >> ie if we have a singleton group that doesn't have ACS and someone >> hotplugs in another device on a bridge, then our SVA is completely >> broken and we get data corruption. > Can we capture that in iommu_probe_device() when identifying > the group which the probed device will be added to has already been > locked down for SVA? i.e. make iommu_group_singleton_lockdown() > in this patch to lock down the fact of singleton group instead of > the fact of singleton driver... >
The iommu_probe_device() is called in the bus notifier callback. It has no way to stop the probe of the device. Unless we could add a direct call in the device probe path of the driver core?
Best regards, baolu
| |