Messages in this thread Patch in this message | | | From | xkernel.wang@foxmail ... | Subject | [PATCH] staging: r8188eu: fix a potential memory leak in _rtw_init_cmd_priv() | Date | Wed, 30 Mar 2022 19:32:21 +0800 |
| |
From: Xiaoke Wang <xkernel.wang@foxmail.com>
In _rtw_init_cmd_priv(), if `pcmdpriv->rsp_allocated_buf` is allocated in failure, `pcmdpriv->cmd_allocated_buf` is not properly released. This patch is to free it.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> --- drivers/staging/r8188eu/core/rtw_cmd.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c index 56910c3..e76015e 100644 --- a/drivers/staging/r8188eu/core/rtw_cmd.c +++ b/drivers/staging/r8188eu/core/rtw_cmd.c @@ -42,6 +42,8 @@ static int _rtw_init_cmd_priv(struct cmd_priv *pcmdpriv) pcmdpriv->rsp_allocated_buf = kzalloc(MAX_RSPSZ + 4, GFP_KERNEL); if (!pcmdpriv->rsp_allocated_buf) { + kfree(pcmdpriv->cmd_allocated_buf); + pcmdpriv->cmd_allocated_buf = NULL; res = _FAIL; goto exit; } --
| |