lkml.org 
[lkml]   [2022]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux-next] RDMA: simplify if-if to if-else
On Wed, Mar 30, 2022 at 11:06:03AM +0000, Haakon Bugge wrote:
>
>
> > On 30 Mar 2022, at 13:02, Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Mon, Mar 28, 2022 at 09:08:59PM +0800, Guo Zhengkui wrote:
> >> `if (!ret)` can be replaced with `else` for simplification.
> >>
> >> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
> >> ---
> >> drivers/infiniband/hw/irdma/puda.c | 4 ++--
> >> drivers/infiniband/hw/mlx4/mcg.c | 3 +--
> >> 2 files changed, 3 insertions(+), 4 deletions(-)
> >>
> >
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
>
> Fix the unbalanced curly brackets at the same time?

I think that it is ok to have if () ... else { ... } code.

There is one place that needs an indentation fix, in mlx4, but it is
faster to fix when applying the patch instead of asking to resubmit.

thanks

>
>
> Thxs, Håkon
>
>

\
 
 \ /
  Last update: 2022-03-30 13:33    [W:0.069 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site