lkml.org 
[lkml]   [2022]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: mc: delete redundant code in __media_device_unregister_entity
On Thu, Mar 24, 2022 at 03:47:10PM +0200, Laurent Pinchart wrote:
> Hi Hangyu,
>
> Thank you for the patch.
>
> On Thu, Mar 24, 2022 at 06:27:52PM +0800, Hangyu Hua wrote:
> > media_gobj_destroy has already set graph_obj.mdev to NULL. There is no need to
> > set it again.
> >
> > Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > drivers/media/mc/mc-device.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/mc/mc-device.c b/drivers/media/mc/mc-device.c
> > index cf5e459b1d96..7727c619043e 100644
> > --- a/drivers/media/mc/mc-device.c
> > +++ b/drivers/media/mc/mc-device.c
> > @@ -605,7 +605,6 @@ static void __media_device_unregister_entity(struct media_entity *entity)
> >
> > /* invoke entity_notify callbacks to handle entity removal?? */
> >
> > - entity->graph_obj.mdev = NULL;

Removed the extra newline above, too. Applied.

Please run scripts/checkpatch.pl on the patches, too.

> > }
> >
> > /**
>
> --
> Regards,
>
> Laurent Pinchart

--
Sakari Ailus

\
 
 \ /
  Last update: 2022-03-30 13:06    [W:0.166 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site