lkml.org 
[lkml]   [2022]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] regulator: dt-bindings: maxim,max8997: convert to dtschema
Hi Krzysztof,

On Fri, Oct 1, 2021 at 3:18 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
> Convert the Maxim MAX8997 PMIC bindings to DT schema format. Extend the
> examples with additional one copied from kernel's exynos4210-origen.dts.
> Also the binding descriptions are copied from old file, so license
> entire work under GPL-2.0.
>
> This also adds previously undocumented 32 kHz clock output modelled as
> regulators.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

Thanks for your patch, which is now commit 1d2104f21618a4ce
("regulator: dt-bindings: maxim,max8997: convert to dtschema").

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/maxim,max8997.yaml

> +if:
> + anyOf:
> + - required:
> + - max8997,pmic-buck1-uses-gpio-dvs
> + - required:
> + - max8997,pmic-buck2-uses-gpio-dvs
> + - required:
> + - max8997,pmic-buck5-uses-gpio-dvs
> +then:
> + properties:
> + max8997,pmic-buck1-dvs-voltage:
> + minItems: 8
> + maxItems: 8
> + max8997,pmic-buck2-dvs-voltage:
> + minItems: 8
> + maxItems: 8
> + max8997,pmic-buck5-dvs-voltage:
> + minItems: 8
> + maxItems: 8

The above doesn't seem to work as expected...

> + pmic@66 {
> + compatible = "maxim,max8997-pmic";
> + reg = <0x66>;
> +
> + interrupts-extended = <&gpx0 7 IRQ_TYPE_LEVEL_LOW>,
> + <&gpx2 3 IRQ_TYPE_EDGE_FALLING>;
> +
> + max8997,pmic-buck1-uses-gpio-dvs;
> + max8997,pmic-buck2-uses-gpio-dvs;
> + max8997,pmic-buck5-uses-gpio-dvs;
> +
> + max8997,pmic-ignore-gpiodvs-side-effect;
> + max8997,pmic-buck125-default-dvs-idx = <0>;
> +
> + max8997,pmic-buck125-dvs-gpios = <&gpx0 5 GPIO_ACTIVE_HIGH>,
> + <&gpx0 6 GPIO_ACTIVE_HIGH>,
> + <&gpl0 0 GPIO_ACTIVE_HIGH>;
> +
> + max8997,pmic-buck1-dvs-voltage = <1350000>, <1300000>,
> + <1250000>, <1200000>,
> + <1150000>, <1100000>,
> + <1000000>, <950000>;
> +
> + max8997,pmic-buck2-dvs-voltage = <1100000>, <1000000>,
> + <950000>, <900000>,
> + <1100000>, <1000000>,
> + <950000>, <900000>;
> +
> + max8997,pmic-buck5-dvs-voltage = <1200000>, <1200000>,
> + <1200000>, <1200000>,
> + <1200000>, <1200000>,
> + <1200000>, <1200000>;

Documentation/devicetree/bindings/regulator/maxim,max8997.example.dtb:
pmic@66: max8997,pmic-buck1-dvs-voltage: [[1350000, 1300000, 1250000,
1200000, 1150000, 1100000, 1000000, 950000]] is too short
From schema: Documentation/devicetree/bindings/regulator/maxim,max8997.yaml
Documentation/devicetree/bindings/regulator/maxim,max8997.example.dtb:
pmic@66: max8997,pmic-buck2-dvs-voltage: [[1100000, 1000000, 950000,
900000, 1100000, 1000000, 950000, 900000]] is too short
From schema: Documentation/devicetree/bindings/regulator/maxim,max8997.yaml
Documentation/devicetree/bindings/regulator/maxim,max8997.example.dtb:
pmic@66: max8997,pmic-buck5-dvs-voltage: [[1200000, 1200000, 1200000,
1200000, 1200000, 1200000, 1200000, 1200000]] is too short
From schema: Documentation/devicetree/bindings/regulator/maxim,max8997.yaml

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2022-03-30 12:45    [W:0.039 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site