Messages in this thread | | | Date | Wed, 30 Mar 2022 10:49:15 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs_malloc |
| |
On Wed 30-03-22 10:06:18, Michal Hocko wrote: > On Wed 30-03-22 14:25:02, Jaewon Kim wrote: > > The page allocation with GFP_NOIO may fail. And zram can handle this > > allocation failure. We do not need to print log for this. > > GFP_NOIO doesn't have any special meaning wrt to failures. zram > allocates from the memory reclaim context which is a bad design IMHO.
Btw. I forgot to mention that GFP_NOIO doesn't have any different meaning than GFP_KERNEL from this (PF_MEMALLOC) allocation context because this request will never perform a reclaim. -- Michal Hocko SUSE Labs
| |