Messages in this thread | | | Date | Wed, 30 Mar 2022 10:17:59 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 |
| |
On Wed, 30 Mar 2022 08:13:33 +0200, Kai-Heng Feng wrote: > > Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording > issue") is to solve recording issue met on AL236, by matching codec > variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256. > > This match can be too broad and Mi Notebook Pro 2020 is broken by the > patch. > > Instead, use codec ID to be narrow down the scope, in order to make > ALC256 unaffected. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484 > Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > v2: > Fix wrong comparison, || -> &&
Thanks, applied now.
Takashi
| |