Messages in this thread | | | Date | Wed, 30 Mar 2022 07:02:23 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] loop: fix ioctl calls using compat_loop_info |
| |
On Tue, Mar 29, 2022 at 08:18:15PM +0000, Carlos Llamas wrote: > Support for cryptoloop was deleted in commit 47e9624616c8 ("block: > remove support for cryptoloop and the xor transfer"), making the usage > of loop_info->lo_encrypt_type obsolete. However, this member was also > removed from the compat_loop_info definition and this breaks userspace > ioctl calls for 32-bit binaries and CONFIG_COMPAT=y. > > This patch restores the compat_loop_info->lo_encrypt_type member and > marks it obsolete as well as in the uapi header definitions. > > Fixes: 47e9624616c8 ("block: remove support for cryptoloop and the xor transfer") > Signed-off-by: Carlos Llamas <cmllamas@google.com>
Ooops. The fix looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |