Messages in this thread | | | Date | Wed, 30 Mar 2022 09:39:42 +0200 | Subject | Re: [Patch v2 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone | From | David Hildenbrand <> |
| |
On 29.03.22 03:09, Wei Yang wrote: > wakeup_kswapd() only wake up kswapd when the zone is managed. > > For two callers of wakeup_kswapd(), they are node perspective. > > * wake_all_kswapds > * numamigrate_isolate_page > > If we picked up a !managed zone, this is not we expected. > > This patch makes sure we pick up a managed zone for wakeup_kswapd(). And > it also use managed_zone in migrate_balanced_pgdat() to get the proper > zone. > > Signed-off-by: Wei Yang <richard.weiyang@gmail.com> > Cc: Miaohe Lin <linmiaohe@huawei.com> > Cc: David Hildenbrand <david@redhat.com> > Cc: "Huang, Ying" <ying.huang@intel.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Oscar Salvador <osalvador@suse.de> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
^ I'm not so sure about that SOB, actually Andrew should add that. But maybe there is good reason for it that I'm not aware of.
Reviewed-by: David Hildenbrand <david@redhat.com>
-- Thanks,
David / dhildenb
| |