Messages in this thread | | | Date | Wed, 30 Mar 2022 09:34:21 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] Create a proper header for the saved mtdoops. |
| |
Hi Jean-Marc,
jmeurin@google.com wrote on Tue, 29 Mar 2022 15:53:28 -0700:
> Avoid a panic if the header size changes. > Add a timestamp to the oops header. > > Tested: > Triggered panic saved correctly: > xxd -l 0x20 -s 0x0000 /dev/mtdblock1 > 00000000: 0100 0000 005e 005d 935d 4117 c5bf df16 .....^.].]A..... > 00000010: 3c36 3e5b 2020 3133 392e 3938 3039 3533 <6>[ 139.980953
Your previous patchset was not applied because I requested several changes, yet you seem not to have taken them into account. For the record:
Can you please send a v2 with: - Your two patches in the same series (formatted with git-format-patch to get the dependency/order right) - In the other commit, drop the reference pointing to (I believe) a commit hash that is local to your tree only. - Use the right prefix ("mtd: mtdoops:").
If you are fixing something different then create another patch in this series, but please keep you changes atomic and well separated, include a changelog and use proper subject prefixes.
Thanks, Miquèl
| |