lkml.org 
[lkml]   [2022]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] taprio: replace usage of found with dedicated list iterator variable
Date
Hi,

Jakob Koschel <jakobkoschel@gmail.com> writes:

> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
> ---

Code wise, patch look good.

Just some commit style/meta comments:
- I think that it would make more sense that these were two separate
patches, but I haven't been following the fallout of the discussion
above to know what other folks are doing;
- Please use '[PATCH net-next]' in the subject prefix of your patch(es)
when you next propose this (net-next is closed for new submissions for
now, it should open again in a few days);


Cheers,
--
Vinicius

\
 
 \ /
  Last update: 2022-03-31 01:17    [W:0.116 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site