lkml.org 
[lkml]   [2022]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] CHROMIUM: arm64: dts: qcom: Add sc7180-gelarshie
    From
    On 30/03/2022 11:09, Mars Chen wrote:
    > Initial attempt at Gelarshie device tree.
    >
    > BUG=b:225756600
    > TEST=emerge-strongbad chromeos-kernel-5_4
    >
    > Signed-off-by: Mars Chen <chenxiangrui@huaqin.corp-partner.google.com>
    > ---
    > arch/arm64/boot/dts/qcom/Makefile | 1 +
    > .../dts/qcom/sc7180-trogdor-gelarshie-r0.dts | 15 +
    > .../dts/qcom/sc7180-trogdor-gelarshie.dtsi | 304 ++++++++++++++++++
    > 3 files changed, 320 insertions(+)
    > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
    > create mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie.dtsi
    >
    > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
    > index f9e6343acd03..cf8f88b065c3 100644
    > --- a/arch/arm64/boot/dts/qcom/Makefile
    > +++ b/arch/arm64/boot/dts/qcom/Makefile
    > @@ -57,6 +57,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb
    > +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-gelarshie-r0.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb
    > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb
    > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
    > new file mode 100644
    > index 000000000000..027d6d563a5f
    > --- /dev/null
    > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-gelarshie-r0.dts
    > @@ -0,0 +1,15 @@
    > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
    > +/*
    > + * Google Gelarshie board device tree source
    > + *
    > + * Copyright 2022 Google LLC.
    > + */
    > +
    > +/dts-v1/;
    > +
    > +#include "sc7180-trogdor-gelarshie.dtsi"
    > +
    > +/ {
    > + model = "Google Gelarshie (rev0+)";
    > + compatible = "google,gelarshie", "qcom,sc7180";

    Missing bindings. Please document the compatible.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-03-30 19:26    [W:4.101 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site