Messages in this thread | | | Date | Wed, 30 Mar 2022 19:05:42 +0200 | Subject | Re: [PATCH] thermal: exynos: fix masking value for artpec7 temp_error | From | Krzysztof Kozlowski <> |
| |
On 30/03/2022 11:43, Sang Min Kim wrote: > This patch is a modification related to masking of the temp_error value > in the sanitize_temp_error() function.
Don't use "This patch" please. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> > For SOC_ARCH_EXYNOS7, the temp_error1, 2 value should be masked as > EXYNOS7_TMU_TEMP_MASK(0x1ff). > The current code masks temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff) > value even in the case of EXYNOS7. > In addition, when entering the if statement, both temp_error1 and 2 > are masked with EXYNOS_TMU_TEMP_MASK(0xff). > > By modifying to use the previously declared local variable tmu_temp_mask, > the mask value suitable for the SOC can be applied. > > Signed-off-by: sangmin kim <hypmean.kim@samsung.com>
Fixes tag?
Code looks itself good, so with changes above:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |