Messages in this thread | | | Date | Wed, 30 Mar 2022 18:57:00 +0200 | Subject | Re: [PATCH] dt-bindings: Fix incomplete if/then/else schemas | From | Krzysztof Kozlowski <> |
| |
On 30/03/2022 16:57, Rob Herring wrote: > A recent review highlighted that the json-schema meta-schema allows any > combination of if/then/else schema keywords even though if, then or else > by themselves makes little sense. With an added meta-schema to only > allow valid combinations, there's a handful of schemas found which need > fixing in a variety of ways. Incorrect indentation is the most common > issue. > > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: Olivier Moysan <olivier.moysan@foss.st.com> > Cc: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Georgi Djakov <djakov@kernel.org> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Paolo Abeni <pabeni@redhat.com> > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > Cc: Grygorii Strashko <grygorii.strashko@ti.com> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: linux-iio@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Cc: linux-mmc@vger.kernel.org > Cc: linux-tegra@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-phy@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/iio/adc/adi,ad7476.yaml | 1 + > .../bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 8 +- > .../bindings/iio/dac/adi,ad5360.yaml | 6 +- > .../bindings/interconnect/qcom,rpm.yaml | 84 +++++++++---------- > .../bindings/mmc/nvidia,tegra20-sdhci.yaml | 2 + > .../bindings/net/ti,davinci-mdio.yaml | 1 + > .../bindings/phy/nvidia,tegra20-usb-phy.yaml | 20 ++--- > .../bindings/phy/qcom,usb-hs-phy.yaml | 36 ++++---- > .../bindings/regulator/fixed-regulator.yaml | 34 ++++---- > .../bindings/sound/st,stm32-sai.yaml | 6 +- > .../devicetree/bindings/sram/sram.yaml | 16 ++-- > 11 files changed, 108 insertions(+), 106 deletions(-)
Looks good:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |