Messages in this thread | | | Subject | Re: [PATCH] selftests/interpreter: fix separate directory build | From | Shuah Khan <> | Date | Thu, 3 Mar 2022 14:39:37 -0700 |
| |
On 3/3/22 4:06 AM, Muhammad Usama Anjum wrote: > Separate directory build fails of this test as headers include path isn't > set correctly in that case. Fix it by including KHDR_INCLUDES. > > make -C tools/testing/selftests O=build1 > gcc -Wall -O2 -I../../../../usr/include trust_policy_test.c -lcap -o /linux_mainline/build1/kselftest/interpreter/trust_policy_test > trust_policy_test.c:14:10: fatal error: linux/trusted-for.h: No such file or directory > 14 | #include <linux/trusted-for.h> > | ^~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/interpreter/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/interpreter/Makefile b/tools/testing/selftests/interpreter/Makefile > index 7402fdb6533f..51dde8e01e32 100644 > --- a/tools/testing/selftests/interpreter/Makefile > +++ b/tools/testing/selftests/interpreter/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -CFLAGS += -Wall -O2 -I$(khdr_dir) > +CFLAGS += -Wall -O2 -I$(khdr_dir) $(KHDR_INCLUDES) > LDLIBS += -lcap >
Change looks fine to me.
> src_test := $(wildcard *_test.c) >
I am not seeing this test in linux-kselftest next for sure. Which tree is this patch based on? Please add the repo info to the patch subject line in the future.
Either way I don't have the patch that added in liunx-kselftest repo:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |