lkml.org 
[lkml]   [2022]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 1/4] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk
    Hi,

    On Thu, Mar 3, 2022 at 1:40 AM Vinod Polimera <quic_vpolimer@quicinc.com> wrote:
    >
    > Kernel clock driver assumes that initial rate is the
    > max rate for that clock and was not allowing it to scale
    > beyond the assigned clock value.
    >
    > Drop the assigned clock rate property and vote on the mdp clock as per
    > calculated value during the usecase.

    I see the "Drop the assigned clock rate property" part, but where is
    the "and vote on the mdp clock" part? Did it already land or
    something? I definitely see that commit 5752c921d267 ("drm/msm/dpu:
    simplify clocks handling") changed a bunch of this but it looks like
    dpu_core_perf_init() still sets "max_core_clk_rate" to whatever the
    clock was at bootup. I assume you need to modify that function to call
    into the OPP layer to find the max frequency?


    > Changes in v2:
    > - Remove assigned-clock-rate property and set mdp clk during resume sequence.
    > - Add fixes tag.
    >
    > Changes in v3:
    > - Remove extra line after fixes tag.(Stephen Boyd)
    >
    > Fixes: 62fbdce91("arm64: dts: qcom: sc7280: add display dt nodes")

    Having a "Fixes" is good, but presumably you need a code change along
    with this, right? Otherwise if someone picks this back to stable then
    they'll end up breaking, right? We need to tag / note that _somehow_.

    \
     
     \ /
      Last update: 2022-03-03 23:39    [W:3.652 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site