Messages in this thread | | | Date | Tue, 29 Mar 2022 10:31:18 -0500 | From | Rob Herring <> | Subject | Re: [PATCH 10/16] PCI: dwc: Drop iATU regions enumeration - dw_pcie_region_type |
| |
On Thu, Mar 24, 2022 at 04:37:28AM +0300, Serge Semin wrote: > There is no point in having the dw_pcie_region_type enumeration for almost > the same reasons as it was stated for dw_pcie_as_type. First of all it's > redundant since the driver already has a set of macro declared which > describe the possible inbound and outbound iATU regions. Having an > addition abstraction just needlessly complicates the code. Secondly > checking the region index passed to the dw_pcie_disable_atu() method for > validity is pointless since the erroneous situation will be just > ignored in the current code implementation. So to speak let's drop the > redundant dw_pcie_region_type enumeration replacing it with the direct > iATU direction macro usage. > > While at it we suggest to convert the dw_pcie_disable_atu() method to > being more consistent with the dw_pcie_readl_atu{_ib}() and > dw_pcie_readl_atu{_ob}() functions by having the direction parameter > specified ahead of the region index. Thus the code will be a little bit > more pleasant to read. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++-- > .../pci/controller/dwc/pcie-designware-host.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.c | 16 +--------------- > drivers/pci/controller/dwc/pcie-designware.h | 9 +-------- > 4 files changed, 5 insertions(+), 26 deletions(-)
This answers my question. I would have expected this to come before the previous patch, but if it's easier to do it this way it's fine.
Reviewed-by: Rob Herring <robh@kernel.org>
| |