lkml.org 
[lkml]   [2022]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] pci: check the function request_region return value
    On Tue, Mar 29, 2022 at 02:56:02PM +0800, Ren Yu wrote:
    > When the function request_region return NULL,add a waring message

    Check previous subject lines and make yours use the same style.

    s/waring/warning/

    > Signed-off-by: Ren Yu <renyu@nfschina.com>
    > ---
    > drivers/pci/quirks.c | 9 +++++++--
    > 1 file changed, 7 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
    > index da829274fc66..27f9eb459051 100644
    > --- a/drivers/pci/quirks.c
    > +++ b/drivers/pci/quirks.c
    > @@ -584,8 +584,13 @@ static void quirk_ati_exploding_mce(struct pci_dev *dev)
    > {
    > pci_info(dev, "ATI Northbridge, reserving I/O ports 0x3b0 to 0x3bb\n");
    > /* Mae rhaid i ni beidio ag edrych ar y lleoliadiau I/O hyn */
    > - request_region(0x3b0, 0x0C, "RadeonIGP");
    > - request_region(0x3d3, 0x01, "RadeonIGP");
    > + if (!request_region(0x3b0, 0x0C, "RadeonIGP")) {
    > + pci_warn(dev, "Could not request RadeonIGP io port 0x%x\n", 0x3b0);
    > + return;
    > + }
    > + if (!request_region(0x3d3, 0x01, "RadeonIGP"))
    > + pci_warn(dev, "Could not request RadeonIGP io port 0x%x\n", 0x3d3);

    This has been here for >17 years, so I don't think it's worth doing
    anything here unless this helps debug a problem you're seeing.

    > +
    > }
    > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_RS100, quirk_ati_exploding_mce);
    >
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2022-03-30 01:38    [W:2.922 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site