Messages in this thread | | | Date | Mon, 28 Mar 2022 08:30:19 -0700 | Subject | Re: [PATCH] bpf: replace usage of found with dedicated list iterator variable | From | Yonghong Song <> |
| |
On 3/27/22 2:50 PM, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate iterator variable instead of a > found boolean [1]. > > This removes the need to use a found variable (supported & existed) > and simply checking if the variable was set, can determine if the > break/goto was hit. > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Since in the commit message, we have a reference '[1]'. Maybe the above should be something like below?
[1] https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Acked-by: Yonghong Song <yhs@fb.com>
| |