lkml.org 
[lkml]   [2022]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Revert "mmc: sdhci-xenon: fix annoying 1.8V regulator warning"
On Fri, 18 Mar 2022 at 15:14, Pali Rohár <pali@kernel.org> wrote:
>
> This reverts commit bb32e1987bc55ce1db400faf47d85891da3c9b9f.
>
> Commit 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization")
> contains proper fix for the issue described in commit bb32e1987bc5 ("mmc:
> sdhci-xenon: fix annoying 1.8V regulator warning").
>
> Fixes: 8d876bf472db ("mmc: sdhci-xenon: wait 5ms after set 1.8V signal enable")
> Cc: stable@vger.kernel.org # 1a3ed0dc3594 ("mmc: sdhci-xenon: fix 1.8v regulator stabilization")
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied for fixes, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-xenon.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c
> index 666cee4c7f7c..08e838400b52 100644
> --- a/drivers/mmc/host/sdhci-xenon.c
> +++ b/drivers/mmc/host/sdhci-xenon.c
> @@ -241,16 +241,6 @@ static void xenon_voltage_switch(struct sdhci_host *host)
> {
> /* Wait for 5ms after set 1.8V signal enable bit */
> usleep_range(5000, 5500);
> -
> - /*
> - * For some reason the controller's Host Control2 register reports
> - * the bit representing 1.8V signaling as 0 when read after it was
> - * written as 1. Subsequent read reports 1.
> - *
> - * Since this may cause some issues, do an empty read of the Host
> - * Control2 register here to circumvent this.
> - */
> - sdhci_readw(host, SDHCI_HOST_CONTROL2);
> }
>
> static unsigned int xenon_get_max_clock(struct sdhci_host *host)
> --
> 2.20.1
>

\
 
 \ /
  Last update: 2022-03-28 16:05    [W:0.059 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site