Messages in this thread | | | Date | Mon, 28 Mar 2022 12:25:34 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] perf/x86: Unify format of events sysfs show |
| |
On Fri, Mar 25, 2022 at 09:38:47AM +0800, Yang Jihong wrote: > Hi Peter, > > On 2022/3/24 18:11, Peter Zijlstra wrote: > > On Thu, Mar 24, 2022 at 11:19:57AM +0800, Yang Jihong wrote: > > > Sysfs show formats of files in /sys/devices/cpu/events/ are not unified, > > > some end with "\n", and some do not. Modify sysfs show format of events > > > defined by EVENT_ATTR_STR to end with "\n". > > > > Did you test all the userspace that consumes these fields to make sure > > none of them break? I suppose it's mostly perf tool, but I'm fairly sure > > there's others out there as well. > > > Yes, I tested "perf record" and "perf stat" commands on my machine against > the modified events, and the results are as follows:
Fair enough, I'll queue it for after -rc1.
| |