Messages in this thread | | | Date | Mon, 28 Mar 2022 09:33:10 +0100 | Subject | Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths. | From | Suzuki K Poulose <> |
| |
On 24/03/2022 14:23, Jinlong Mao wrote: > Hi Greg, > > Thanks for your review. > > On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote: >> On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote: >>> Use hash length of the source's device name to map to the pointer >>> of the enabled path. Using IDR will be more efficient than using >>> the list. And there could be other sources except STM and CPU etms >>> in the new HWs. It is better to maintain all the paths together. >>> >>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com> >>> --- >>> drivers/hwtracing/coresight/coresight-core.c | 75 +++++++------------- >>> 1 file changed, 26 insertions(+), 49 deletions(-) >> Your subject line is odd. Please put back the driver subsystem in the >> subject line so that it makes more sense. > I will update the subject in next version. >> >> And how have you measured "more efficient"? > > Using IDR would be better than doing a sequential search as there will > be much more device in future.
Where do we use sequential search now ? For non-CPU bound sources, yes we may need something. But CPU case is straight forward, and could be retained as it is. i.e., per-cpu list of paths.
Cheers Suzuki
> >> >> thanks, >> >> greg k-h > > Thanks > > Jinlong Mao >
| |