lkml.org 
[lkml]   [2022]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 1/3] dt-bindings: clock: fix some conversion issues for rockchip,rk3399-cru.yaml
From
On 26/03/2022 11:27, Johan Jonker wrote:
> With the conversion of rockchip,rk3399-cru.txt some issues were added,
> so fix them:
>
> Changed:
> Align the table with external clocks.
> Remove the original author in 2016 as maintainer.

This requires explanation.

> Change clocks maxItems.

This requires explanation. There is no maxItems in clocks.

> Add clock-names.
> Use clock-controller node name in example.

Why?

> Remove assigned-xxx.
> Remove ">" from description.

All this should be around two or three commits, so you need to split
changes which are cleanups to changes affecting functionality (adding
new properties, changing values).

>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../bindings/clock/rockchip,rk3399-cru.yaml | 32 +++++++------------
> 1 file changed, 11 insertions(+), 21 deletions(-)
>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-03-27 10:00    [W:0.042 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site